docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

Add TiCDC TSO acquisition in sync-diff-inspector doc

Open teckick opened this issue 3 years ago • 8 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fix #11217

Add TiCDC TSO acquisition in sync-diff-inspector doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v6.3 (TiDB 6.3 versions)
  • [x] v6.1 (TiDB 6.1 versions)
  • [x] v5.4 (TiDB 5.4 versions)
  • [x] v5.3 (TiDB 5.3 versions)
  • [x] v5.2 (TiDB 5.2 versions)
  • [x] v5.1 (TiDB 5.1 versions)
  • [x] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

teckick avatar Sep 05 '22 11:09 teckick

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 05 '22 11:09 ti-chi-bot

/cc @reviewer

teckick avatar Sep 05 '22 12:09 teckick

@eastfisher: GitHub didn't allow me to request PR reviews from the following users: reviewer.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @reviewer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Sep 05 '22 12:09 ti-chi-bot

/cc @3pointer

teckick avatar Sep 05 '22 12:09 teckick

Why is this PR merged first? https://github.com/pingcap/docs-cn/pull/11273

teckick avatar Sep 24 '22 12:09 teckick

@TomShawn

my PR is pending for reviewing but #11273 has been merged which do the similar work.

teckick avatar Sep 24 '22 13:09 teckick

Thank you very much for creating this PR and contributing to TiDB documentation. We greatly appreciate your work. The TiCDC syncpoint is an experimental feature. It should have been properly documented as an experimental feature, but to our regret, it is not documented at all. Users cannot find the keyword "syncpoint".

As the TiCDC team plans to make it GA in the upcoming v6.3, they created https://github.com/pingcap/docs-cn/pull/11273 to fully introduce the concept of syncpoint, without knowing the existence of this PR. I think this PR should have been reviewed by the TiCDC team @asddongmen instead of @3pointer. Anyway, I think this PR is still a very good complement to https://github.com/pingcap/docs-cn/pull/11273. @asddongmen Could you please take a look?

TomShawn avatar Sep 26 '22 02:09 TomShawn

I'm very sorry for not noticing your PR before. The TiCDC team has improved the syncpoint function and modified some configuration of it. After the work was done, I made changes to this part of the document. Now that the configuration and description of the syncpoint function are different from before, I have modified the content of your PR after review. Thanks a lot for your contribution!

asddongmen avatar Oct 11 '22 06:10 asddongmen

/verify

shichun-0415 avatar Oct 11 '22 06:10 shichun-0415

/status LGT2

shichun-0415 avatar Oct 19 '22 06:10 shichun-0415

/merge

shichun-0415 avatar Oct 19 '22 06:10 shichun-0415

This pull request has been accepted and is ready to merge.

Commit hash: e432a724a3c05a09e094d73c135d0a126f80484e

ti-chi-bot avatar Oct 19 '22 06:10 ti-chi-bot

/verify

shichun-0415 avatar Oct 19 '22 08:10 shichun-0415

/merge

shichun-0415 avatar Oct 19 '22 08:10 shichun-0415

In response to a cherrypick label: new pull request created: #11691.

ti-chi-bot avatar Oct 19 '22 08:10 ti-chi-bot