bl_iot_sdk icon indicating copy to clipboard operation
bl_iot_sdk copied to clipboard

Linter applied for flash_build.py

Open BubaVV opened this issue 5 years ago • 3 comments

BubaVV avatar Oct 28 '20 17:10 BubaVV

Uh, that are quite a lot of changes. I worry that this will result in a lot of merge conflicts with upstream code.

schaecsn avatar Oct 28 '20 19:10 schaecsn

Both ' and " are allowed, if one was already picked I wouldn't really change it. It will indeed cause merge conflicts if built upon.

Avamander avatar Oct 28 '20 21:10 Avamander

only FYI: this looks like black was applied.

This is certainly useful for new code, but compatibility with existing code is important, too (practicality beats purity).

serv-inc avatar Oct 30 '20 19:10 serv-inc