pimoroni-pico icon indicating copy to clipboard operation
pimoroni-pico copied to clipboard

Published 20 hours ago • verified publisher icon pimoroni

Allow specifying a background color for image_converter

Open North101 opened this issue 3 years ago • 3 comments

Add a --bg option to image_converter.py with the choices black or white. This is useful for converting images with transparency.

North101 avatar Jul 31 '22 22:07 North101

Woops just realized it formatted on save. I'll redo the commit without that

North101 avatar Aug 01 '22 10:08 North101

Thank you!

Could you rebase this on main, please? A new version of flake8 broke our Python linting and this is stopping me from merging.

Gadgetoid avatar Aug 08 '22 09:08 Gadgetoid

Thank you!

Could you rebase this on main, please? A new version of flake8 broke our Python linting and this is stopping me from merging.

Done. I was wondering if it should default to white. Currently img.convert("1") converts transparency to black

North101 avatar Aug 08 '22 16:08 North101

White might be a sensible default if you're willing and able to make the tweak.

Sorry for the delay getting back, I have been stacked!

Gadgetoid avatar Feb 07 '23 15:02 Gadgetoid

The new and shiny Badger 2040 W library has been backported to Badger 2040 and moved here- https://github.com/pimoroni/badger2040

Both now have JPEG support, so converting bin files is ancient history and this converter will probably either get deleted, or expanded to support all PicoGraphics pen types and rehosted somewhere.

Either way, I'm closing this PR since all Badger python stuff is going to be removed from "pimoroni-pico"

And- once again- thank you!

Gadgetoid avatar Mar 09 '23 20:03 Gadgetoid

No worries, I agree that theres no point merging this.

North101 avatar Mar 09 '23 20:03 North101