zf-doctrine-hydration-module icon indicating copy to clipboard operation
zf-doctrine-hydration-module copied to clipboard

by_value option not respected

Open Bilge opened this issue 9 years ago • 1 comments
trafficstars

Regardless of the by_value setting, AbstractMongoStrategy::hydrateCollection always attaches AllowRemoveByValue strategy. When by_value is false it should attach AllowRemoveByReference instead.

Bilge avatar Nov 26 '15 12:11 Bilge

The hydration of the object still respects the by_value configuration. The strategy is something that is configured to extract / hydrate a property. So the strategy does not NEED to respect the hydrator. It is something stand-alone that is attached to the hydrator.

I agree that in an ideal situation you could choose between the strategy base class. However this won't be an easy fix. It is also not a good idea to create duplicate strategies just to respect the by_value configuration of the main hydrator. We will propably have to think this one through.

veewee avatar Dec 01 '15 08:12 veewee