Stick-Hero-Swift icon indicating copy to clipboard operation
Stick-Hero-Swift copied to clipboard

Published 20 hours ago • verified publisher icon phpmaple

Code suggestion

Open RKDUDE02 opened this issue 5 years ago • 2 comments

I notice that in GameViewController.swift that when it tries to play a sound it prints NO AUDIO PLAYER. Instead maybe we could use a UIAlert Controller telling the user that sound is not working.

RKDUDE02 avatar Jul 22 '20 22:07 RKDUDE02

I notice that in GameViewController.swift that when it tries to play a sound it prints NO AUDIO PLAYER. Instead maybe we could use a UIAlert Controller telling the user that sound is not working.

Yep, right! We should fully-tested In pre production, and If audio files not exist we should send error message to our server instead of alert message to user, that will be better for user, this program just demonstrate, very good suggestion!

phpmaple avatar Jul 27 '20 02:07 phpmaple

I notice that in GameViewController.swift that when it tries to play a sound it prints NO AUDIO PLAYER. Instead maybe we could use a UIAlert Controller telling the user that sound is not working.

Yep, right! We should fully-tested In pre production, and If audio files not exist we should send error message to our server instead of alert message to user, that will be better for user, this program just demonstrate, very good suggestion!

That's even better so that we can handle it. But quick question, do we already have servers or do we need to add some? And if we need to add some i suggest that we use firebase.

RKDUDE02 avatar Jul 27 '20 15:07 RKDUDE02