phpbb

phpbb copied to clipboard

Checklist:

• [x] Correct branch: master for new features; 3.3.x for fixes
• [ ] Tests pass
• [x] Code follows coding guidelines: master and 3.3.x
• [x] Commit follows commit message format

PHPBB3-16935.

Why does the checks always fails at phpbb_functional_visibility_softdelete_test::test_split_topic ? 🤔

Failures are random, depending on the weather and github's mood.

Failures are random, depending on the weather and github's mood.

nah! it's at phpbb_functional_visibility_softdelete_test::test_split_topic Only !!!

I see also: phpbb_functional_search_sphinx_test::test_search_backend

That's because I'm debugging the issue so failures vary. The actual one is test_split_topic which I didn't figure out yet. Same code works fine for master but not for 3.3.x. Sphinx search works here but not for splitting topic.

We have uncovered the whole mystery, you are the cause of everything. 😃

Currently the main cause I suppose is incorrect search indexing of edited posts -> topic titles in 3.3.x Sphinx search backend which is not the case for master for some reason.

We have uncovered the whole mystery, you are the cause of everything. 😃

I can see you are in very good mood today, did you flip your "Funny" mode ?

It's Christmas time, it's short term. 🎅🏼

Confirmed that edited posts don't get into delta index on 3.3.x. No clue where's the culprit in the code though.

Closed and reopened to force GitHub to run the tests again. Couldn't restart them directly. 🤷

This code works for master but not for 3.3.x for some reason. Probably different tests order affects or something.

Closed and reopened to force GitHub to run the tests again. Couldn't restart them directly.

@marc1706 Actions in the menu here on GH. Should be able to rerun specific (failing) tests. No need to close/reopen PR.

I've played around a bit with this but it really seems like tests don't want to work on 3.3.x. Will just close this PR as it's already working on master.