The nice present: core phpstan tags vs. our phpstan tags in WordPress 6.5

Needs change in functionMap.php

@IanDelMar

Stop adding our tag if a tag with the same name is already present.

https://github.com/php-stubs/wordpress-stubs/blob/794559556de631c52b98349890956d306ac38884/visitor.php#L402

What is to be fixed? https://github.com/php-stubs/wordpress-stubs/pull/162/commits/6ef2cf0ab49fdf2c98ebfb53c4c41994e43e573d

@johnbillion Has core started adding @phpstan-* tags in 6.5?

Nope

So we could have these collisions in earlier stubs? I do not see one in git diff v6.3.3..v6.4.0

Some @phpstan-tag annotations are now appearing because someone made changes to the core doc comment, allowing the node visitor to handle the doc comment without functionMap.php.

Some @phpstan-tag annotations are now appearing because someone made changes to the core doc comment, allowing the node visitor to handle the doc comment without functionMap.php.

But I thought we had checks for the functionMap.php already in place to catch such things.

But I thought we had checks

We need a Superhero, Ian.

Do any of you, Superheroes have a idea what to do?

I'll have a look on the weekend.

Only thing that could happen is that you have a newer version of php parser.

https://github.com/phpDocumentor/ReflectionDocBlock/issues/365

It's not the parser...

Compare this from a version with missing phpstan tags with this from a version with intact phpstan tags