phlex-rails

phlex-rails copied to clipboard

underscore internal stream methods

2

Vagab

I'm new to Phlex and am submitting this PR to a gotcha that got me. The docs explain that you can render a component by calling `call` on it. Because...

andrewjanssen

resolves #220

Vagab

We should raise an error if you try to use a helper from an initializer

1

See this discussion as an example of this happening https://github.com/orgs/phlex-ruby/discussions/767

joeldrapper

`raw_buffer` on `ActionView::OutputBuffer` is only available from Rails 7.1. Currently the gem requires `railties >= "6.1"` which is incorrect. https://github.com/phlex-ruby/phlex-rails/blob/f39547c75f4fca59869f99ddb3a58ef1f6659ec4/lib/phlex/rails/sgml/state.rb#L5

paulfri

By default caching in turned off in development mode. To toggle this we run `rails dev:cache` that will toggle `config.action_controller.perform_caching`. However, when `config.action_controller.perform_caching` is `false`, Phlex is still caching in...

peterberkenbosch

With a clean [Rails edge application](https://github.com/peterberkenbosch/phlex-demo) the cache hit is not returning any content. Tried with: * [`Phlex::FIFOCacheStore`](https://github.com/peterberkenbosch/phlex-demo/commit/f0b0b88ba0a3d1d48fad0f105ad09a78b3da749f) * [Rails default `memory_store`](https://github.com/peterberkenbosch/phlex-demo/commit/a8a18b4eb9dbdbeeba7ac23e28c2dc250b6148e0) * [SolidCache](https://github.com/peterberkenbosch/phlex-demo/commit/f69e790835a178a7426016a0486704e531c4c413c) The cache is stored, so the...

peterberkenbosch

Update helper casing

1

Rails appears to have recently corrected the casing of some of their helper methods, e.g. `text_area -> textarea` and `check_box -> checkbox`. We should update the adapters to match, while...

joeldrapper

Warn when using `options_for_select` as a value

1

Closes #249

joeldrapper

## Summary Fixes the CI build failure caused by deprecated Bundler `--without` flag. ## Problem ``` The `--without` flag has been removed because it relied on being remembered across bundler...

mhenrixon