betterer

betterer copied to clipboard

Describe the bug No Betterer problems appear on VS Code when the Betterer extension is installed

To Reproduce I have initialized my Betterer project using npx @betterer/cli init and currently 2671 issues exist

My betterer.ts file is defined as;

import { typescript } from '@betterer/typescript';

export default {
  'strictNullChecks compilation': () =>
    typescript('./tsconfig.json', {
      strictNullChecks: true
    }).include('./src/**/*.ts')
};

Expected behavior I expect the Problems tab on VS Code to show Betterer problems

Observed behavior

These are logs from the Betterer Output Terminal

[Info  - 11:41:41 am] Server: Clearing diagnostics for "file:///c%3A/Users/xxxx/Documents//app/ui/tsconfig.json".
[Info  - 11:41:41 am] Server: Removing "file:///c%3A/Users/xxxx/Documents/app/ui/tsconfig.json" from validation queue at 2023-01-23T00:41:41.464Z
[Info  - 11:43:16 am] Server: file:///c%3A/Users/xxxx/Documents/app/ui/.betterer.results opened, validating:
[Info  - 11:43:16 am] Server: Adding "file:///c%3A/Users/xxxx/Documents/app/ui/.betterer.results" to validation queue at 2023-01-23T00:43:16.721Z
[Info  - 11:43:16 am] Server: Processing queue at 2023-01-23T00:43:16.721Z
[Info  - 11:43:16 am] Server: Validating document "file:///c%3A/Users/xxxx/Documents/app/ui/.betterer.results".
[Info  - 11:43:16 am] Validator: Folders: 1, Documents: 1
[Info  - 11:43:16 am] Validator: About to run Betterer.
[Info  - 11:43:16 am] Validator: Setting CWD to "c:\Users\xxxx\Documents\app\ui".
[Info  - 11:43:16 am] Validator: Getting Betterer for "c:\Users\xxxx\Documents\app\ui".
[Info  - 11:43:16 am] Validator: Getting Betterer config.
[Info  - 11:43:16 am] {"cache":true,"cachePath":"c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.cache","configPaths":["c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.ts"],"cwd":"c:\\Users\\xxxx\\Documents\\app\\ui","filters":[".*"],"resultsPath":"c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.results","silent":true}
[Info  - 11:43:16 am] Validator: Not running Betterer, no documents need updating.
[Info  - 11:43:16 am] Validator: Restoring CWD to "C:\Program Files\Microsoft VS Code".
[Info  - 11:43:16 am] Server: file:///c%3A/Users/xxxx/Documents/app/ui/tsconfig.json opened, validating:
[Info  - 11:43:16 am] Server: Adding "file:///c%3A/Users/xxxx/Documents/app/ui/tsconfig.json" to validation queue at 2023-01-23T00:43:16.979Z
[Info  - 11:43:16 am] Server: Processing queue at 2023-01-23T00:43:16.979Z
[Info  - 11:43:16 am] Server: Validating document "file:///c%3A/Users/xxxx/Documents/app/ui/tsconfig.json".
[Info  - 11:43:16 am] Validator: Folders: 1, Documents: 1
[Info  - 11:43:17 am] Validator: About to run Betterer.
[Info  - 11:43:17 am] Validator: Setting CWD to "c:\Users\xxxx\Documents\app\ui".
[Info  - 11:43:17 am] Validator: Getting Betterer for "c:\Users\xxxx\Documents\app\ui".
[Info  - 11:43:17 am] Validator: Getting Betterer config.
[Info  - 11:43:17 am] {"cache":true,"cachePath":"c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.cache","configPaths":["c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.ts"],"cwd":"c:\\Users\\xxxx\\Documents\\app\\ui","filters":[".*"],"resultsPath":"c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.results","silent":true}
[Info  - 11:43:17 am] Validator: Running Betterer in "c:\Users\xxxx\Documents\app\ui".
[Info  - 11:43:17 am] Validator: Running Betterer on "["c:\\Users\\xxxx\\Documents\\app\\ui\\tsconfig.json"]."
[Error - 11:43:17 am] Validator: Error: Cannot find module './register'
Require stack:
- c:\Users\xxxx\Documents\app\ui\node_modules\@betterer\betterer\dist\betterer.js
- c:\Users\xxxx\Documents\app\ui\node_modules\@betterer\betterer\dist\index.js
- c:\Users\xxxx\.vscode\extensions\betterer.betterer-vscode-5.2.1\dist\server\server.js
[Info  - 11:43:17 am] Validator: Restoring CWD to "C:\Program Files\Microsoft VS Code".

Versions:

OS: Windows 10 Pro 64-bit Betterer Version 5.4 Node Version 16.15.0 Betterer VSC Extension Version: 5.2.1

Error: Cannot find module './register'

^ This is super interesting! Does the problem go away if you restart VS Code?

I have restarted VS Code, the following logs came up. The same error and no change was overserved in the problems tab

[Info  - 12:39:14 pm] Server: Betterer server running in node v16.14.2
[Info  - 12:39:14 pm] Betterer is running.
[Info  - 12:39:14 pm] Server: file:///c%3A/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts opened, validating:
[Info  - 12:39:14 pm] Server: Adding "file:///c%3A/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts" to validation queue at 2023-01-23T01:39:14.169Z
[Info  - 12:39:14 pm] Server: Processing queue at 2023-01-23T01:39:14.170Z
[Info  - 12:39:14 pm] Server: Validating document "file:///c%3A/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts".
[Info  - 12:39:14 pm] Validator: Folders: 1, Documents: 1
[Info  - 12:39:14 pm] Validator: About to run Betterer.
[Info  - 12:39:14 pm] Validator: Setting CWD to "c:\Users\xxxx\Documents\app\ui".
[Info  - 12:39:14 pm] Validator: Getting Betterer for "c:\Users\xxxx\Documents\app\ui".
[Info  - 12:39:14 pm] Validator: Getting Betterer config.
[Info  - 12:39:14 pm] {"cache":true,"cachePath":"c:\\Users\\xxx\\Documents\\app\\ui\\.betterer.cache","configPaths":["c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.ts"],"cwd":"c:\\Users\\xxxx\\Documents\\app\\ui","filters":[".*"],"resultsPath":"c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.results","silent":true}
[Info  - 12:39:14 pm] Validator: Running Betterer in "c:\Users\xxxx\Documents\app\ui".
[Info  - 12:39:14 pm] Validator: Running Betterer on "["c:\\Users\\xxxx\\Documents\\app\\ui\\src\\app\\shared\\services\\store.service.ts"]."
[Error - 12:39:15 pm] Validator: Error: Cannot find module './register'
Require stack:
- c:\Users\xxxx\Documents\app\ui\node_modules\@betterer\betterer\dist\betterer.js
- c:\Users\xxxx\Documents\app\ui\node_modules\@betterer\betterer\dist\index.js
- c:\Users\xxxx\.vscode\extensions\betterer.betterer-vscode-5.2.1\dist\server\server.js
[Info  - 12:39:15 pm] Validator: Restoring CWD to "C:\Program Files\Microsoft VS Code".

Oooh do you have --debug enabled somehow? Or BETTERER_DEBUG set?

Are you referring to this setting?

Yes, if you turn that off does it work? It's something I need to remove, but just curious if that fixes it!

This seems to change the logs shown in the Output tab.

The following error does not come up now

Error: Cannot find module './register'

The new logs are;

[Info  - 1:05:43 pm] Server: Betterer server running in node v16.14.2
[Info  - 1:05:43 pm] Betterer is running.
[Info  - 1:05:43 pm] Server: file:///c%3A/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts opened, validating:
[Info  - 1:05:43 pm] Server: Adding "file:///c%3A/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts" to validation queue at 2023-01-23T02:05:43.773Z
[Info  - 1:05:43 pm] Server: Processing queue at 2023-01-23T02:05:43.773Z
[Info  - 1:05:43 pm] Server: Validating document "file:///c%3A/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts".
[Info  - 1:05:43 pm] Validator: Folders: 1, Documents: 1
[Info  - 1:05:43 pm] Validator: About to run Betterer.
[Info  - 1:05:43 pm] Validator: Setting CWD to "c:\Users\xxxx\Documents\app\ui".
[Info  - 1:05:43 pm] Validator: Getting Betterer for "c:\Users\xxxx\Documents\app\ui".
[Info  - 1:05:44 pm] Validator: Getting Betterer config.
[Info  - 1:05:44 pm] {"cache":true,"cachePath":"c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.cache","configPaths":["c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.ts"],"cwd":"c:\\Users\\xxxx\\Documents\\app\\ui","filters":[".*"],"resultsPath":"c:\\Users\\xxxx\\Documents\\app\\ui\\.betterer.results","silent":true}
[Info  - 1:05:44 pm] Validator: Running Betterer in "c:\Users\xxxx\Documents\app\ui".
[Info  - 1:05:44 pm] Validator: Running Betterer on "["c:\\Users\\xxxx\\Documents\\app\\ui\\src\\app\\shared\\services\\store.service.ts"]."
[Info  - 1:05:47 pm] Validator: No issues from Betterer for "strictNullChecks compilation"
[Info  - 1:05:47 pm] Validator: Sending 0 diagnostics to "file:///c%3A/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts".
[Info  - 1:05:47 pm] Validator: Restoring CWD to "C:\Program Files\Microsoft VS Code".

However, I see no errors on the Problem tab.

When I do run npm run betterer results the app/shared/services/store.service.ts is shown to have issues

  Object is possibly 'undefined'. - C:/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts:150:8
  Object is possibly 'undefined'. - C:/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts:156:26
  Object is possibly 'undefined'. - C:/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts:163:24
  Object is possibly 'undefined'. - C:/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts:169:24
  Argument of type 'string | undefined' is not assignable to parameter of type 'string'. - C:/Users/xxxx/Documents/app/ui/src/app/shared/services/store.service.ts:186:28
    Type 'undefined' is not assignable to type 'string'.

The logs above don't seem to pick these issues up;

["c:\Users\xxxx\Documents\app\ui\src\app\shared\services\store.service.ts"]." [Info - 1:05:47 pm] Validator: No issues from Betterer for "strictNullChecks compilation" [Info - 1:05:47 pm] Validator: Sending 0 diagnostics to

i am having the same issue here, Error: cannot find module './register'

i can confirm that disabling Debug fixes it and it now shows issue properly