generator-gadget

generator-gadget copied to clipboard

Following from discussion in https://github.com/phase2/grunt-drupal-tasks/pull/160 Gadget should provide a Drupal 8 version of the eslintrc, and Gadget can provide improvements of the Drupal 7 version.

cc @mdeltito @grayside

In Drupal 8, the drupal-scaffold script is pulling down Drupal's top-level .eslintrc file, which consists of

{
  "extends": "./core/.eslintrc"
}

Presumably, we could have gadget extend from that one and simply lean on core. Unfortunately, that would introduce a dependency from grunt validate to Drupal docroot, something we don't have yet. The move to composer to build the Drupal docroot has significantly mitigated this as a concern, but it could still lead to problems in edge cases.

Another approach would be to remove .eslintrc from gadget, and instead have composer copy Drupal core's .eslint to the project root. This tries for the best of both worlds: no strong dependency on the docroot, and the build process will update "source" configuration as needed. This is a bit of a side-effect abuse, as normally we avoid changing files that are committed when we run the build process.

Marking this as a question as this needs further discussion to select a course.