pgmpy icon indicating copy to clipboard operation
pgmpy copied to clipboard

`DAG.to_pdag()` not implemented

Open behrman opened this issue 3 years ago • 10 comments

Currently DAG.to_pdag() is stub that always returns None. This could confuse users. It would probably be best to leave the method out completely until it has been implemented.

The dagitty package provides this functionality with equivalenceClass() (doc, pp. 13 - 14). The code that implements this is the JavaScript function GraphTransformer.dagToCpdag() (code, lines 1167 - 1184) with unit tests (code, lines 64 - 69).

@ankurankan

behrman avatar Apr 14 '23 19:04 behrman

@behrman Thanks for reporting this. I will remove the method for now till it is implemented.

ankurankan avatar Apr 18 '23 04:04 ankurankan

@ankurankan If you can remember, please comment to this thread when DAG.to_pdag()has been implemented. I will update the pgmpy tutorial I've written to include an illustration of its use.

behrman avatar Apr 18 '23 04:04 behrman

Can I contribute in making of the function DAG.to_pdag() ?

parthrastogicoder avatar Jul 10 '24 20:07 parthrastogicoder

@parthrastogicoder Yeah, that would be great. Feel free to reach out to me if you need any help with it.

ankurankan avatar Jul 10 '24 20:07 ankurankan