simpleICP icon indicating copy to clipboard operation
simpleICP copied to clipboard

(C++) 1-based index

Open mitjap opened this issue 4 years ago • 0 comments

I've noticed that in some places you used 1-based indices. I guess all of this should be 0-based?

https://github.com/pglira/simpleICP/blob/1478851961c01eab677bd325f93dff9b85d7a069/c%2B%2B/src/simpleicp.cpp#L164 https://github.com/pglira/simpleICP/blob/1478851961c01eab677bd325f93dff9b85d7a069/c%2B%2B/src/simpleicp.cpp#L181 https://github.com/pglira/simpleICP/blob/1478851961c01eab677bd325f93dff9b85d7a069/c%2B%2B/src/pointcloud.cpp#L82

mitjap avatar Mar 03 '22 09:03 mitjap