python-bitcoinlib

python-bitcoinlib copied to clipboard

do you have plan to support bip32

3

That is about deterministic wallet https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki

xuanzhui

Fix on from_scriptPubKey accept_bare_checksig

1

` import bitcoin import bitcoin.rpc from bitcoin.core import * from bitcoin.core.script import CScript, IsLowDERSignature from bitcoin.core.key import CPubKey from bitcoin.wallet import * proxy = bitcoin.rpc.Proxy(service_url="mainnet url", timeout=10) chash = proxy.getrawtransaction(lx("e7a3e246c6f2d582b089d7d6c2f925e8aae46ef0c0ce97d3dd3afe3016a44e97"))...

fcmercury

When i try to retrieve this transaction (this transaction is on the testnet3): `2301c07b4953640338d06b481f99487f1e165173190a7a6ab861d13b2c08c186` the json rpc client stopped and is halted for a lot of time, is normal to...

Bedotech

https://github.com/bitcoin/bips/pull/673#issuecomment-380671415

petertodd

Error: File "/usr/lib/python3.4/json/decoder.py", line 361, in raw_decode raise ValueError(errmsg("Expecting value", s, err.value)) from None

6

Got this program: ``` import bitcoin.rpc proxy_connection = bitcoin.rpc.RawProxy(service_url='http://127.0.0.1', service_port=44555) print(proxy_connection.getnewaddress()) ``` When I'm trying to execute it got error: ``` Traceback (most recent call last): File "electrum_to_clam.py", line 5,...

Serasar

in spend-p2pkh-txout.py line 67: sig = seckey.sign(sighash) + bytes([SIGHASH_ALL]) should be: sig = seckey.sign(sighash) + b'\x01' otherwise VerifySignature will fail. The same issue exists in spend-p2sh-txout.py

goldenfiredo

Maybe I'm missing something, but shouldn't this: ```python >>> uint256_from_compact(0x1d00ffff) 26959535291011309493156476344723991336010898738574164086137773096960L ``` return this? ```python 26959946667150639794667015087019630673637144422540572481103610249215L ``` More info from my tests: ```python >>> m = int('0x00000000FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF', 16) >>> m...

caioariede

Bignum handling is dodgy

2

Doesn't appear we handle bignums > 32bits correctly, and the code itself is uncommented, undocumented, and doesn't handle errors in any sane way.

petertodd

Need to look into this part of the API and check the design. For instance bad messages raise ValueError exceptions right now rather than a specific serialization error, making error...

petertodd

In modern version of openssl (iirc from 1.1) the library `libeay32` is removed in favour of libcrypto. See for more info https://github.com/openssl/openssl/issues/10332 This commit adds the possibility to include libcrypto...

vincenzopalazzo