python-bitcoinlib icon indicating copy to clipboard operation
python-bitcoinlib copied to clipboard

Published 20 hours ago • verified publisher icon petertodd

Use 'params=None' approach

Open Flowdalic opened this issue 10 years ago • 3 comments

As discussed in https://github.com/petertodd/python-bitcoinlib/pull/38 I suggest the following approach.

Flowdalic avatar Jan 03 '15 12:01 Flowdalic

Do you have any code that uses this that I can look at?

petertodd avatar Jan 04 '15 02:01 petertodd

@petertodd I've extended the commit with a unit test that uses the params argument: https://github.com/Flowdalic/python-bitcoinlib/commit/33501188a4bed3c678423a195a00c7593e9d5ba0#diff-ee9d866ca82462d5999da2d94c1b3ec9R29

Flowdalic avatar Jan 07 '15 08:01 Flowdalic

Hey, sorry I haven't merged this yet, travelling. :(

Mind writing up a thing in the README explaining the idea behind params, like as a code best practices? I wanted to do that before I merge, but stupid busy.

petertodd avatar Jan 18 '15 14:01 petertodd