api

api copied to clipboard

This is the small change to start sending bounding boxes to pelias/query per https://github.com/pelias/query/pull/124

I ran this over 1000 queries pulled from commoncrawl. I see 40 diffs - 36 wins, 1 loss, 2 neutral.

The loss is the same as the oakland query - exact match in an adjoining town - "text": "515 Chestnut St, Reading, PA 19602". Will continue thinking about how to fix that. Open to ideas.

The diff with my scores is attached, it can be viewed at https://radarlabs.github.io/api-diff/compare.html (need to rename it to .json, github doesn't allow attaching .json????) ranked-diff-2020-07-22T13_07_54.074Z.txt

I threw in a commit to use your pelias/query branch. If you can polish off the tests, I'll run this through a bunch of address tests and report back :)

tests fixed + added

On Fri, Jul 24, 2020 at 8:30 AM Julian Simioni [email protected] wrote:

I threw in a commit to use your pelias/query branch. If you can polish off the tests, I'll run this through a bunch of address tests and report back :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pelias/api/pull/1475#issuecomment-663515181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMZMGKHTGITWTN7PD7KCLR5F5H3ANCNFSM4PCZGCMA .

-- David Blackman creative technologist & wandering help me find my purpose http://purpose.blackmad.com

I just noticed that the debug output from this branch renders the controller:placeholder bounding_box section as a string vs. an object on the production server..

It isn't immediately clear what change might have that effect 🤷

prod

dev