api

api copied to clipboard

I have been seeing this message in the logs "Fallback scenarios should not result in address or venue records!"

It's coming from middleware/confidenceScoreFallback.js and presumably, the original author didn't expect this to happen?

The logs were generated from running the acceptance tests

This might be related to what I discovered while creating https://github.com/pelias/api/pull/1334, which came out of a bug report from https://github.com/pelias/api/issues/1280.

As it turns out, the confidenceScoreFallback middleware is being used much more widely than it was originally intended, and while it is operating outside of its intended functionality, looking at the results we actually prefer results as they are now.

So the real fix would be to expand the expected usage of that middleware, possibly removing the other confidenceScore middleware, and likely fixing this issue in the process.