Pedro Pedreira

Results 36 comments of Pedro Pedreira

Fixed in https://github.com/facebookincubator/velox/issues/2789

> Should not it be vectorSize == 0 || size > 0 to be consistent with the error message? Hi @randosrandom . The assertion is a bit hard to read,...

Hi @gosharz , the plan in your first comment makes sense. Checking `isTimestampWithTimeZoneType()` and in that case generating a single nullability vector and using it for both children should work....

@gosharz are you going to be working on this Issue as well?

I don't see any reason why arrow should be enabled on that job. Feel free to remove that flag.

Assuming this is still in progress - re-opening it.

Hi @lsyldliu, thanks for reaching out! As we work on expanding Velox's reach and growing our open soruce community, we are certainly interested in providing integrations with other widely adopted...

@svm1 looks like a bunch of builds are failing.

@czentgr thank you for the investigation and detailed explanation! The problem with downgrading is that we need to have a consistent version of FBOS across all facebook dependencies, and we...