react-native-modal-selector icon indicating copy to clipboard operation
react-native-modal-selector copied to clipboard

Styling selector to look like a native android component

Open jadeirving9 opened this issue 5 years ago • 3 comments

Hi, I really like the component and don't want to use anything else because it has a wealth of accessible functionality, which my application requires. However, the component does not fit with the rest of my application. Is there a way to drop the styling so it looks like a native component? It's ok on iOS but on Android it looks like an iOS component. Thanks

jadeirving9 avatar Feb 27 '20 11:02 jadeirving9

There are a number of styling props to make it look the way you prefer, though admittedly there are quite a lot to change: https://github.com/peacechen/react-native-modal-selector#props

Making the default an Android style would disrupt iOS apps. Ideally this library would support themes, possibly with default styles for Android vs iOS. The app uses a typical stylesheet that could be overridden by a prop: https://github.com/peacechen/react-native-modal-selector/blob/master/index.js#L17

It could also check the platform OS and select between Android vs iOS default stylesheets.

Would you be interested in submitting a PR?

peacechen avatar Feb 28 '20 20:02 peacechen

So, there aren't specific style props I can 'reset', I would have to re-style the whole thing?

jadeirving9 avatar Mar 01 '20 10:03 jadeirving9

It probably wouldn't look like "Android" if all the styling was removed. If you'd like to try, pass in an empty array [] to all the style props.

This a community supported open source library. Your contributions would help not only yourself but others who use this.

peacechen avatar Mar 01 '20 17:03 peacechen