Pavlos-Petros Tournaris comments

Results 62 comments of


                                            Pavlos-Petros Tournaris

feat: Allow access to keypairs for Karpenter controller policy

This PR still shouldn’t close IMO!

feat: Allow access to keypairs for Karpenter controller policy

Nope!

[meta-task] Kotlin outstanding issues

@passy `@PropDefault` does not work for which cases? Is there a branch with Kotlin sample available?

[meta-task] Kotlin outstanding issues

@passy Have you tried `@get:PropDefault val something = 1f` for example ?

[meta-task] Kotlin outstanding issues

Ok, great! Will wait to check that commit tomorrow :) Please ping it here as well in case I miss it :P

[meta-task] Kotlin outstanding issues

@passy My colleagues usually say the same thing, no wonder why 😂

[meta-task] Kotlin outstanding issues

Hey @kar , you can find Kotlin-powered samples inside the repository! Check `sample-barebones-kotlin` and `sample-kotlin` for more details :)

[meta-task] Kotlin outstanding issues

@passy I think it can be closed and also remove the `IMPORTANT` notice from this doc: https://github.com/facebook/litho/blob/master/docs/_docs/getting-started/gradle-kt.md

[meta-task] Kotlin outstanding issues

@passy sure sounds reasonable!

[Gradle Increment annotation] Warning for test components.

@colriot TestingProcessors were explicitly left out of IAP support. I can add support for the rest but I am not sure if this is needed. Also I am not sure...