Paul Miller comments

Results 594 comments of


                                            Paul Miller

Rage is 38% slower at encrypting than Go implementation

What about parallelism / multicore usage? Anything we could do here?

Rage is 38% slower at encrypting than Go implementation

rust go brrrrrr

Rage is 38% slower at encrypting than Go implementation

I assume STREAM is still not parallel? I'd focus on this instead of using low-level dangerous `asm` code.

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

[@scure/bip39](https://www.npmjs.com/package/@scure/bip39) used in snaps is smaller, supports tree shaking, and works on byte arrays. It has also been audited and is used in EF's repo [ethereum-cryptography](https://github.com/ethereum/js-ethereum-cryptography).

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

> low-effort local attack vectors that involve dumping browser memory >low-effort >dumping browser memory Seems like a joke to me.

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

As a side note: making `@scure/bip39` not use mnemonics takes 2 lines of code. But i'm sure you're very wrong here if you are doing this and I can describe...

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

Okay, that makes sense. The reason I had this tone is that "dumping browser memory" meant extremely complex attacks which cannot be easily tested against, also garbage collector provides no...

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

@adonesky1 what is your flow? What happens when a user enters phrase into the input? In what format you store it?

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

It should work like this: ```ts // words is an array of words here export function mnemonicToEntropy(mnemonic: string, wordlist: string[]): Uint8Array { const { words } = normalize(mnemonic); const entropy...

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

Everything is doable. Just requires more work. The code i've mentioned is the simplest one that can be done with just a few changes — where you will pass wordlist...