chokidar icon indicating copy to clipboard operation
chokidar copied to clipboard

Published 20 hours ago • verified publisher icon paulmillr

Fix filter pattern not being applied to files inside symlink subdirectories of the watched path

Open samuelneff opened this issue 1 year ago • 4 comments

This PR resolves issue #967 and applies the pattern filter to files nested inside symlinks.

No change in expected behavior or usage. New passing test added.

samuelneff avatar Feb 14 '24 22:02 samuelneff

I'll address those issues, assuming they're real issues (lint at least probably is). 👍

samuelneff avatar Feb 15 '24 04:02 samuelneff

@paulmillr It looks like none of the errors are actually related to my PR but are existing issues. This particular one is with DTS Lint and a missing function.

samuelneff avatar Feb 15 '24 18:02 samuelneff

As i’ve mentioned, we can’t really merge new code unless we fix the old tests.

Otherwise some stuff could get broken and we wouldn’t even know.

Thanks for the pr.

paulmillr avatar Feb 15 '24 18:02 paulmillr

Thanks for the update. I missed that specific message about the tests. I'll work on those next. 👍

samuelneff avatar Feb 15 '24 18:02 samuelneff