plugin-drupal-twig-components
plugin-drupal-twig-components copied to clipboard
pattern-lab
Hello 👋 I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@rudloff) has found a potential issue, which I would be eager to share with...
Improved version of #10 Uses [sghoweri's snippet](https://github.com/pattern-lab/plugin-drupal-twig-components/pull/10#issuecomment-403172065).
Replicates the Drupal twig function create_attribute for patternlab https://www.drupal.org/docs/8/theming/twig/functions-in-twig-templates#create_attribute #8 got me thinking about this, so used existing `link` twig function to make `create_attribute` work in Pattern Lab. Tested locally...
I ran into an issue with this because it was expecting a third parameter, which isn't necessarily necessary.
``create_attribute()`` is a new twig function in Drupal core 8.3.x https://www.drupal.org/node/2818293 The ``Attribute`` class contains a lot of logic, i am not sure if we should copy it, trim it...
I think I discovered a bug in Pattern Lab with the view all link. This bug relates to this PL: - http://mayflower.digital.mass.gov/ - https://github.com/massgov/mayflower 1. View all link doesn't show...
I would feel more comfortable using the clean_class filter in my pattern-lab templates if I was confident it would do the same in Pattern Lab as it does in Drupal.
Probably a fair argument that attach_library doesn't belong in your patterns in the first place, but if you find yourself in that position for some reason it would be nice...
i know I know, this doesn't do anything. The problem is that right now, even if I make sure the pattern lab side will never actually hit this filter, its...
