Patrick Arminio

I'll finish this in the weekend if that's ok :)

Sorry folks! I was travelling, I just pushed the changes, thanks for the nudges @eddiemoore @simsim0709 :) @DorianGrey this should be fine to merge now, as soon as I fix...

Ok, I'm not sure why it fails, @DorianGrey can you tell me how to run the single failing test locally? I had troubles with docker unfortunately

@DorianGrey yeah, I saw that, I was able to run the kitchensink locally but with no luck, it seems like it using an old version of the scripts, I even...

@DorianGrey it seems that we need to pass `--scripts-version=react-scripts-ts` to ``` npx create-react-app --internal-testing-template="$root_path"/packages/react-scripts/fixtures/kitchensink test-kitchensink ``` so it will load the correct scripts, but the test fails still, with a...

Yup, but without it we are testing the wrong scripts right? I'm happy to do another PR with the updated tests if that's ok :)

@DorianGrey the e2e tests are passing, even if I emptied the `webpack.config.prod.js` file. It seems to me that is actually using the standard create react app to run the tests...

Yup, it is using a different template for the application files, but it seems to be that it is still using the `react-scripts` package for the configuration, it seems also...

So, this fix the test we should force the kitchensink to use `react-scripts-ts` and update the template as well, right? I might work on it this weekend

+1