substrate icon indicating copy to clipboard operation
substrate copied to clipboard

added add_member_to_rank with sudo origin

Open MrishoLukamba opened this issue 3 years ago • 5 comments

First PR, solving this issue, adding new extrinsic @shawntabrizi @ggwpez

The other PR is not clear.

MrishoLukamba avatar Aug 22 '22 14:08 MrishoLukamba

Solving issue paritytech/polkadot-sdk#262

MrishoLukamba avatar Aug 22 '22 14:08 MrishoLukamba

So there are two Merge Requests now for the exposing of add_member_to_rank?
You could just have fixed the other one, but anyway. Please close the out-dated one so we dont get confused.

ggwpez avatar Aug 22 '22 15:08 ggwpez

Done closing the other ones

MrishoLukamba avatar Aug 22 '22 15:08 MrishoLukamba

bot rebase

shawntabrizi avatar Sep 21 '22 22:09 shawntabrizi

Rebased

bot rebase

@Ank4n @kianenigma

MrishoLukamba avatar Sep 30 '22 16:09 MrishoLukamba

bot rebase

ggwpez avatar Sep 30 '22 17:09 ggwpez

Rebased

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 31 '22 02:10 stale[bot]

The PR is complete waiting for review only @ggwpez @bkchr

MrishoLukamba avatar Oct 31 '22 07:10 MrishoLukamba

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 30 '22 13:11 stale[bot]

Code looks good. Please make the CI green.
The main changes for rebasing: Origin renamed to RuntimeOrigin and Weight should be u64 now in the weight file.

ggwpez avatar Nov 30 '22 15:11 ggwpez

bot rebase

ggwpez avatar Nov 30 '22 15:11 ggwpez

Rebased

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-check-benches Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2103322

paritytech-cicd-pr avatar Nov 30 '22 15:11 paritytech-cicd-pr

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-check-benches Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2103321

paritytech-cicd-pr avatar Nov 30 '22 15:11 paritytech-cicd-pr

@MrishoLukamba if you want this to be merged, please make CI happy. Otherwise please close.

bkchr avatar Dec 07 '22 16:12 bkchr

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 06 '23 23:01 stale[bot]