polkadot icon indicating copy to clipboard operation
polkadot copied to clipboard

update weights

Open coderobe opened this issue 3 years ago • 10 comments
trafficstars

new weights as requested by @shawntabrizi

draft until the other benches are done

coderobe avatar Sep 19 '22 21:09 coderobe

this was run off d17f0627

coderobe avatar Sep 19 '22 21:09 coderobe

/cmd queue -v RUST_LOG=debug -c bench-bot $ runtime kusama-dev pallet_balances

shawntabrizi avatar Sep 20 '22 19:09 shawntabrizi

@shawntabrizi https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1864571 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" runtime kusama-dev pallet_balances. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 41-68d77c72-0436-41d4-b2c1-c58b40841f82 to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot[bot] avatar Sep 20 '22 19:09 command-bot[bot]

@shawntabrizi Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" runtime kusama-dev pallet_balances has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1864571 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1864571/artifacts/download.

command-bot[bot] avatar Sep 20 '22 20:09 command-bot[bot]

Interesting. There are some big increases, but also a lot of decreases.
Remark jumped to 1.46ms, but it seems consistent across the runtimes. Westend was not updated @coderobe?

SWC-compare link link and PDF for posterity.

ggwpez avatar Sep 20 '22 21:09 ggwpez

westend wasn't ready when i opened the PR - it is now, i'll add the files.

coderobe avatar Sep 20 '22 21:09 coderobe

There are some changes here we should look into, but i feel pretty confident after looking over this, that the changes that @koute made are solid, and probably we need to hunt separately what is going on

Thanks @coderobe

shawntabrizi avatar Sep 20 '22 21:09 shawntabrizi

doesn't compile, however

coderobe avatar Sep 20 '22 21:09 coderobe

Looks like an error in the template, should be easy to resolve, will look into it

shawntabrizi avatar Sep 20 '22 21:09 shawntabrizi

Looks like an error in the template, should be easy to resolve, will look into it

Could also just be missing deps in runtime/kusama/constants/Cargo.toml.
PS I think we can and should get rid of that sub-crate and just put it into the runtime.

ggwpez avatar Sep 20 '22 21:09 ggwpez

Regarding the merge conflicts: its since we renamed anonymous to pure. I will do a git merge -X theirs origin/master.

ggwpez avatar Sep 27 '22 13:09 ggwpez