reth icon indicating copy to clipboard operation
reth copied to clipboard

fix(evm): validate EIP-7685 requests root against the header

Open shekhirin opened this issue 1 year ago • 2 comments

Ref https://github.com/paradigmxyz/reth/issues/8301

shekhirin avatar May 17 '24 15:05 shekhirin

noting here: this is to solve a specific case where a block was built with withdrawal requests that do not actually appear in the requests generated by execution. the spec (7685) is a bit unclear on when to check requests root, so currently we do it in engine api + bodies downloader and now in execution

it is my understanding that extra validation was left up to individual eips, for example 6110 has extra validation, but the withdrawals request eip does not.

i think we merge this, note down that this is not really clear and/or specced, and ask for clarification for devnet1

onbjerg avatar May 17 '24 15:05 onbjerg

Testing on kurtosis rn

shekhirin avatar May 17 '24 15:05 shekhirin