quart icon indicating copy to clipboard operation
quart copied to clipboard

Accept AsyncIterables being passed to Response

Open mjsir911 opened this issue 1 year ago • 4 comments

Fixes pallets/flask#5322

Checklist:

  • [x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • [x] Add or update relevant docs, in the docs folder and in code.
  • [ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • [ ] Add .. versionchanged:: entries in any relevant code docs.
  • [ ] Run pre-commit hooks and fix any issues.
  • [ ] Run pytest and tox, no tests failed.

mjsir911 avatar May 20 '24 13:05 mjsir911

I want to add tests for this somehow

mjsir911 avatar May 20 '24 13:05 mjsir911

@davidism ready for review, would like extra eyes on the test specifically

mjsir911 avatar May 20 '24 14:05 mjsir911

Add an entry in CHANGES.rst summarizing the change and linking to the issue.

I've been told I don't need to do this and it will be gotten to later.

mjsir911 avatar May 20 '24 14:05 mjsir911

It would be cool if ResponseValue in typing.py could be updated too but adding AsyncIterator[bytes] or similar causes a lot of errors.

mjsir911 avatar May 20 '24 18:05 mjsir911

Is there anything stopping this from being merged?

CoolCat467 avatar Oct 31 '24 04:10 CoolCat467

Merged manually in a80358bbe27a10f5ec709760e62ac3930bbedee7 to fix conflict

pgjones avatar Nov 14 '24 20:11 pgjones