Petr Spacek

Results 14 comments of Petr Spacek

> Are you also planning to contribute `CodeAction` changes? I didn't plan it (I needed some customized functionality in client, so I didn't need it in YLS), but I can...

> Please resolve the conflicts Hello, I merged the code and resolved conflicts, there were some problems with the test. I would suggest reviewing it again?. I left a little...

hello @msivasubramaniaan, any comments on this PR, please?

@gorkem can you please consider this PR it will also fix another issue (see updated description 3) ) I think that `getNodeFromPosition` doesn't work correctly with arrays (check the previous...

> This should be setting to exclude them. Otherwise, LSPs do have a way to mark deprecated code completions as deprecated and we should actually use that mechanism instead of...

Oh, I understand now. Sorry for the late reply. So I think that I need `doNotSuggest` schema property to exclude something from code-completion **Note1: current implementation excludes properties with `deprecationMessage`**...

Hello @msivasubramaniaan, can I ask you for a review, please?

> Yes, if you want to make a PR against the json-language-service that would be great. Note that `doNotSuggest` is internal and we don't want to advertise this. But if...

Hello @msivasubramaniaan, can I ask you for a review, please?

@gorkem any updates here, please? check updates and answers Can you please rerun the jobs? It failed because of unavailable jsonSchemaStore