smenu icon indicating copy to clipboard operation
smenu copied to clipboard

Published 20 hours ago • verified publisher icon p-gen

Completion of error handling

Open elfring opened this issue 8 years ago • 4 comments

Would you like to add more error handling for return values from functions like the following?

elfring avatar Dec 19 '16 18:12 elfring

Can you be more precise? The "usage" function returns no value and the value returned by "parse_sed_like_string" is already tested.

p-gen avatar Dec 19 '16 22:12 p-gen

I suggest to avoid ignorance of return values a bit more. How do you think about to care also if a file output or a string copy really succeeded?

elfring avatar Dec 20 '16 07:12 elfring

Looks to me as this issue was resolved on same day - but the issue was not closed.

The return value for strdup are handled now with the changes in https://github.com/p-gen/smenu/commit/768f82bbe75abbbc88fbc5fad57252cc2dde8208 And ignoring the return value of *printf functions is usually not considered that a relevant issue - at least not, when this is done during output of help messages to stdout.

markschuh avatar Jul 29 '23 08:07 markschuh

:thought_balloon: Would it matter if output redirection can occasionally fail?

elfring avatar Jul 29 '23 08:07 elfring