client icon indicating copy to clipboard operation
client copied to clipboard

SHA1 checksums computed twice?

Open michaelstingl opened this issue 3 years ago • 0 comments

Pre-submission Checks

  • [X] I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • [X] I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

While searching for something different, I discovered the line Computing "SHA1" checksum twice for the same file.

Expected behavior

I hope, SHA1 checksum is only computed once.

Steps to reproduce the issue

No response

Screenshots

No response

Logs

08-11 10:09:45:849 [ info sync.propagator ]:	Starting SyncInstruction(CSYNC_INSTRUCTION_NEW) propagation of "Example Files/Video Files/big_buck_bunny_480p_h264.mov-00.00.00.000-00.04.50.029.mov" by OCC::PropagateUploadFileTUS(0x6000034901b0)
08-11 10:09:45:849 [ info sync.checksums ]:	Computing "SHA1" checksum of "/Users/michaelstingl/testpilotcloud/Personal/Example Files/Video Files/big_buck_bunny_480p_h264.mov-00.00.00.000-00.04.50.029.mov" in a thread
08-11 10:09:46:126 [ info sync.checksums ]:	Computing "SHA1" checksum of "/Users/michaelstingl/testpilotcloud/Personal/Example Files/Video Files/big_buck_bunny_480p_h264.mov-00.00.00.000-00.04.50.029.mov" in a thread
08-11 10:09:46:364 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::startNextChunk ]:	Starting creation with upload: "/Example Files/Video Files/big_buck_bunny_480p_h264.mov-00.00.00.000-00.04.50.029.mov"
08-11 10:09:46:364 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::makeCreationWithUploadJob ]:	FullPath: "/Example Files/Video Files/big_buck_bunny_480p_h264.mov-00.00.00.000-00.04.50.029.mov"
08-11 10:09:46:364 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::startNextChunk ]:	Offset: 0 0 Chunk: 100000000 0

Client version number

testpilotcloud 3.0.0.8306-daily20220811 e81c9b Aug 11 2022 02:10:42
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: suffix
osx-21.6.0

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

https://ocis.team.owncloud.works

Additional context

Capabilities:

                    "checksums":
                    {
                        "supportedTypes":
                        [
                            "sha1",
                            "md5",
                            "adler32"
                        ],
                        "preferredUploadType": "SHA1"
                    },

michaelstingl avatar Aug 11 '22 09:08 michaelstingl