ghubber

ghubber copied to clipboard

Hey!

We needed button for merge inside on PR page :)

THank

Hey I would like to take this one, but before that, I have some issues with running your project on iOS simulator, I keep getting errors about wrong import paths, eg. you import something from 'actions', which is one folder up, so if I replace it with '../actions' it works, but I don;t want to do it for every import statement :) so how can I keep it as in your code but without errors? Thanks!

@brascene did you start packer manually by npm run start instead of auto?

@ovr no, I started it with react-native start

@brascene please use npm run start & review https://github.com/ovr/ghubber#way-1

Thank

@ovr thank you, I'll check it later today and start with button :) one quicky: what PR screen stands for?

@brascene PR = Pull Request, you can open any pull request from the Feed (it's main screen after login)

@ovr thanks, I was thinking maybe it's some shortcut for one of your components or screens. I've did what you said about running packager with npm run start, but now I receive another issue, and that is:

• build has failed with this info: (The following build commands failed: PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images build/Build/Intermediates/ghubber.build/Debug-iphonesimulator/ghubber.build/Script-E8A627B61EE1AFDD00BF818A.sh (1 failure))
• even though, application starts in the simulator, but with unhandled promise rejection: Invariant Violation: SideMenuDrawer.render(): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object. Any idea?

build has failed with this info: (The following build commands failed: PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images build/Build/Intermediates/ghubber.build/Debug-iphonesimulator/ghubber.build/Script-E8A627B61EE1AFDD00BF818A.sh (1 failure))

You can ignore this error, it's not a problem

even though, application starts in the simulator, but with unhandled promise rejection: Invariant Violation: SideMenuDrawer.render(): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object. Any idea?

Looks like this problem comes in latest commits in master, I am going to fix it

@brascene Problem was fixed in https://github.com/ovr/ghubber/commit/fd1eba9e968c8f524d33d3c1fcddd449de5de496 😸

Great, finally can start adding that button xD So, where should this button be placed? Inside the PR list specific item, or after you open PR in another view? ,

After PR body & before reaction group