node-ovh icon indicating copy to clipboard operation
node-ovh copied to clipboard

Published 20 hours ago • verified publisher icon ovh

Fix issue #3: HTTPS proxy support through custom agent

Open debrouxl opened this issue 10 years ago • 3 comments

I implemented the outcome of the discussion in issue #3 , and made a quick local test from behind an HTTPS proxy, which accessed the server successfully.

As far as naming is concerned, maybe the property in params should be named "httpsAgent" for consistency, or the "https" / "HTTPS" strings should go away ?

debrouxl avatar Aug 17 '15 12:08 debrouxl

Thanks for your contribution! Quality is a must-have for OVH. Can you provide relevant tests and documentation for this patch? Thanks.

yadutaf avatar Aug 20 '15 22:08 yadutaf

  • do you mean that you'd like to see more documentation comments, a note in the readme, or / in addition to something else ?
  • unit testing would require going through a real HTTP proxy. Would a trivial proxy (pure request forward) created by the test infrastructure for the sole purpose of testing be acceptable ?

debrouxl avatar Aug 24 '15 09:08 debrouxl

Still no support for proxy settings ?

loganmzz avatar Mar 20 '20 15:03 loganmzz