csharp-ovh

csharp-ovh copied to clipboard

Just update framework target as these .net libraries are about to be not supported.

Hello,

According to this documentation, .NET Framework is far from being deprecated. Updating to netstandard2.1 would entirely drop its support, and this is not something we want. That said, netcoreapp2.0 is indeed deprecated, and upgrading the test project to netcoreapp3.1 makes sense.

Regarding the .NET Standard version, were you motivated by a specific need? As far as I'm aware of, any project that is compatible with netstandard2.1 will be compatible with netstandard2.0, but there might be a case I don't see. 🙂

EDIT: If you wish to update the pull-request according to what has been said above, please take a look at the CONTRIBUTING section, especially the Signed-off-by part.

Hi,

Indeed thank you for the precision! .netcoreapp2.0 is the framework that is deprecated. If we wish to update the test project to netcoreapp3.1, we must update the library to netstandard2.1according to this documentation.

I don't see any regression using .netstandard2.1, and I have executed unit tests.

What motivated me to do this were 2 reason :

• Using the project for a solution made up of other netcoreapp3.1 projects
• Execute the unit tests on VS 2019 as test execution did not work when the project was compiled with netcoreapp2.0

Ok for the sign-off part, I've modified the pull request. Do you wish to have it in the commit comment or in the pull request title ?

Regards,

The documentation you linked lists the minimum compatible versions:

• netstandard2.0 is compatible with all versions of .NET Core after netcoreapp2.0
• netstandard2.1 is compatible with all versions of .NET Core after netcoreapp3.0

Which is equivalent to:

• netcoreapp2.0 is only compatible with netstandard2.0
• netcoreapp3.0 is compatible with both netstandard2.0 and netstandard2.1

In your situation, you should be able to use this library on a netcoreapp3.1. 🙂 have you experienced issues installing the NuGet package?

Side note: the Signed-off-by must be on the commit, not in the issue title. 😉Something like that:

Your commit message here

Signed-off-by: Your Name <[email protected]>