bun icon indicating copy to clipboard operation
bun copied to clipboard

Published 20 hours ago • verified publisher icon oven-sh

chore: swap install counter and package name

Open aw1875 opened this issue 1 year ago • 2 comments
trafficstars

What does this PR do?

Takes the naive approach to swap the order of the install counter with the package name/step (closes https://github.com/oven-sh/bun/issues/14124). This change doesn't take into consideration the splitting of the icon from the rest of the package name.

image

  • [ ] Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • [x] Code changes

How did you verify your code works?

Ran several manual eye tests on both the debug and release versions on several different projects. Not entirely sure if there's a "good" way to compare against the output_buffer but I'm open to writing zig tests if there is.

aw1875 avatar Oct 02 '24 23:10 aw1875

merge pls

okineadev avatar Nov 01 '24 17:11 okineadev

Please add "Closes #14124" to the PR description so that when this PR is merged, my issue is automatically closed

okineadev avatar Nov 02 '24 05:11 okineadev

@RiskyMH merge please

okineadev avatar Dec 09 '24 07:12 okineadev

@Jarred-Sumner I'm guessing this was closed as it isn't relevant anymore?

aw1875 avatar Jun 24 '25 15:06 aw1875

@Jarred-Sumner I'm guessing this was closed as it isn't relevant anymore?

He recently closed a lot of different PRs

Maybe to focus on more important things

okineadev avatar Jun 24 '25 16:06 okineadev