Oskar Pearson

Results 29 comments of Oskar Pearson

A note here on ruby-jwt versions: I've tested this with both the beta version of ruby-jwt and recent versions of ruby-jwt (2.10.1, 2.6, 2.5) and they also work. I've thus...

## NOTE to the messagebird reviewers: PLEASE *SET A RELEASE LABEL* on this PR before merging. You should be able to find this on the right hand side of the...

> @oskarpearson another small request: please add a unit test 🙏 ? Thanks for the review, @marcelcorso 🎉 I had a look at this, and encountered a few issues. Wanted...

@marcelcorso Wanted to check in here - we're running this in production without any incidents. Could you let me know what approach you'd like me to take with the tests?

Hi @Stylecraftbeanbag Can you explain what verify3 does, and why it should be included in the main repo? My suggestion is to close this PR

Great to hear this. I've checked and it seems the above commit is included in [8.1.0.beta1](https://github.com/rails/rails/blob/80827ca7ff33ca3026f2c74fe8249ccc6f513318/activerecord/lib/active_record/schema_dumper.rb#L195)

Thanks for the useful and thoughtful reply @delner - it's good to know this was intentional rather than accidental. It would be great to find a different solution for my...

>One thing occurred to me is adding a after action in the controller/sidekiq engine and then looping through Datadog::Tracing.active_trace spans. Would that better fit with your intentions? FWIW I've investigated...

Thanks again @delner for the long reply! > The code ownership gem is interesting. > > > * On the sidekiq side I've created middleware that finds the code owner...