Or Shoval

Results 337 comments of Or Shoval

atm we have a problem that some IDEs don't index symbols correct because the IDE try to fetch toolchain 1.22 that doesn't exists https://github.com/golang/go/issues/61455#issuecomment-2072931029 with this PR it fixes it...

@RamLavi is it fine to try and merge https://github.com/kubevirt/kubevirt/pull/11874 meanwhile please? it will fix IDEs problems unless this PR will be merged soon, wdyt ? Thanks

> ✋🧢 > > /hold > > Dear @sradco > > ⚠️ this pull request exceeds the number of retests that are allowed per individual commit. > > 🔎 Please...

/test pull-kubevirt-e2e-k8s-1.29-sig-network new utils.go file is not a good idea :)

> IMO it doesn't make sense to have `ovn-k8s` in the PR's title. > > This is a k8snetworkplumbingwg feature, and that's just an implementation. removed (also from commit)

Changes: Support standalone VMI Addressed comments beside the following: https://github.com/kubevirt/kubevirt/pull/11410#discussion_r1511256758 (crd deployment) https://github.com/kubevirt/kubevirt/pull/11410#discussion_r1511193999 (create more unit tests) https://github.com/kubevirt/kubevirt/pull/11410#issuecomment-1976708079 (Edy's request) https://github.com/kubevirt/kubevirt/pull/11410#discussion_r1511101185 (GetNetworkToResourceAndIPAMMap refactor, discussion) https://github.com/kubevirt/kubevirt/pull/11410#discussion_r1511110957 (GenerateMultusCNIAnnotation refactor about the new...

change: just a little cosmetic, moved the var next to its usage

change: reverted small changes that aren't relevant anymore to this PR

Changes per push: 1. First try to create the IPAMClaim, and if failed use get to validate it. also assert the claim has OwnerReferences before accessing it (so if a...

Added `PersistentIPs` FG