hydra icon indicating copy to clipboard operation
hydra copied to clipboard

feat: wrap the final response from /oauth2/authorize in a transaction

Open alnr opened this issue 2 years ago • 1 comments

Primarily, this is a performance enhancement when using CockroachDB global tables.

alnr avatar Aug 04 '23 08:08 alnr

Codecov Report

Merging #3595 (5b1505f) into master (eb89af7) will decrease coverage by 0.08%. Report is 1 commits behind head on master. The diff coverage is 70.21%.

:exclamation: Current head 5b1505f differs from pull request most recent head fa79917. Consider uploading reports for the commit fa79917 to get more accurate results

@@            Coverage Diff             @@
##           master    #3595      +/-   ##
==========================================
- Coverage   76.39%   76.31%   -0.08%     
==========================================
  Files         130      130              
  Lines        9746     9766      +20     
==========================================
+ Hits         7445     7453       +8     
- Misses       1799     1807       +8     
- Partials      502      506       +4     
Files Changed Coverage Δ
cmd/server/handler.go 1.33% <0.00%> (-0.04%) :arrow_down:
consent/handler.go 65.07% <ø> (+0.90%) :arrow_up:
x/clean_sql.go 90.90% <0.00%> (-0.21%) :arrow_down:
oauth2/handler.go 65.66% <36.36%> (-1.48%) :arrow_down:
consent/strategy_default.go 68.97% <100.00%> (+0.47%) :arrow_up:
persistence/sql/persister_oauth2.go 84.88% <100.00%> (-0.65%) :arrow_down:

codecov[bot] avatar Aug 04 '23 09:08 codecov[bot]

All important changes from this PR are on master already, with the exception of the transaction which is done in https://github.com/ory/hydra/pull/3763/files

aeneasr avatar May 07 '24 12:05 aeneasr