organicmaps
[android] SpeedLimitView
Finally! It's an improvement, but there's more to consider.
We need to decide on a location for it. In portrait mode, it looks good. However, in landscape mode, it might overlap with buttons. If we opt to move this sign to the right corner, we'll need to address the issues with lanes beforehand.
https://github.com/organicmaps/organicmaps/assets/10351358/76ac99db-ef52-4483-adbd-fc8e4a421f8f
Thanks!
- Is there any reason for not moving the right buttons to the bottom in the landscape mode? @Jean-BaptisteC @arnaudvergnet
- Space on the left under the direction sign is also used for the next turn. And it looks unbalanced with the right part of the screen.
- Lane arrows UI should be rewritten #1404 #1104, then the position of the speed limit indicator may change.
- Now in portrait on Android, where lanes are already implemented, it can be displayed as in the screenshot above if the lanes widget size will be automatically scaled down to see all lanes.
- The size of the speed limit indicator can be slightly reduced.
- Note that many roads don't have any limits, so the speed limit will appear and disappear frequently.
- A current speed can be displayed under the speed limit (a separate task).
Moved view to the top right corner in the land mode. Fixed bug with incorrect rounding. Need to move right buttons to the bottom (separate PR).
I'm working to update layouts not fit with RTL, it's can be good to remove LTR forced in new layout
Might a MUTCD red #bd2025 (instead of this pure red) look better in the speed limit widget? I think the current hue might look a little garish in some screens. (Iām not married with the exact color value; someone could adjust it to conform to a palette.)
A proper solution is to reduce size of SpeedLimitView and down a little buttons at the right in landscape. In the future, it could be good to rethink the navigation screen and reduce the number of items present to have more space to see the road.
This is PR is 99% ready. It would be nice to tune sizes and margins to get it merged in April.
I believe this implementation is currently overly intrusive. Is it possible to implement this inside of the bar at the bottom of the screen or somewhere similar?
I believe this implementation is currently overly intrusive. Is it possible to implement this inside of the bar at the bottom of the screen or somewhere similar?
On iOS, the speed limit is part of the speed indicator as 51/50 (also red text if you're exceeding the limit) but I'm not too bothered about this current implementation if it's a bit smaller.
On iOS, the speed limit is part of the speed indicator as 51/50 (also red text if you're exceeding the limit) That implementation seems ideal, as it doesn't invade the ui too much for those that don't need it, and is still perfectly useful for those who do. There is also no need for localization for places like the US which doesn't use the red circle for speed limit signs, and no need for any kind of layout change.
On May 9, 2024 5:09:41 AM CDT, CaldeiraG @.***> wrote:
I believe this implementation is currently overly intrusive. Is it possible to implement this inside of the bar at the bottom of the screen or somewhere similar?
On iOS, the speed limit is part of the speed indicator as 51/50 (also red text if you're exceeding the limit) but I'm not too bothered about this current implementation if it's a bit smaller.
-- Reply to this email directly or view it on GitHub: https://github.com/organicmaps/organicmaps/pull/7005#issuecomment-2102363572 You are receiving this because you commented.
Message ID: @.***>
Hello, I'm very interested in this feature. Is there anything we can do to help regarding this pull request ?
