vagrant-projects icon indicating copy to clipboard operation
vagrant-projects copied to clipboard

Published 20 hours ago • verified publisher icon oracle

Add a commented-out option to allow a private network for PL/SQL debu…

Open CBatemanOracle opened this issue 2 years ago • 2 comments

…gging.

CBatemanOracle avatar May 23 '23 00:05 CBatemanOracle

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

  • PR author: @CBatemanOracle

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

oracle-contributor-agreement[bot] avatar May 23 '23 00:05 oracle-contributor-agreement[bot]

I like this idea, but I have a couple of comments.

  • If this is implemented, I think it should be done for all of the single instance database projects, not just 19.3.0.
  • I think it should be configured using environment variables (and, optionally, the vagrant-env plugin), to be consistent with the other configurable parameters, and to make it unnecessary to modify the Vagrantfile.
  • I don't think the 192.168 address range will work for the libvirt provider.
  • I think the README.md file should be updated to include this enhancement.

PaulNeumann avatar May 23 '23 01:05 PaulNeumann