opengrok icon indicating copy to clipboard operation
opengrok copied to clipboard

diff links would be a nice to have in the file history view (Bugzilla #19172)

Open vladak opened this issue 12 years ago • 2 comments

status NEW severity enhancement in component webapp for --- Reported in version unspecified on platform ANY/Generic Assigned to: Lubos Kosco

On 2012-02-13 11:15:48 +0000, Konrad Karczewski wrote:

In 0.11 the history view allows to see all of the files that were modified by given changeset. The links point to the revision of the file created by this changeset. It would be nice to have a link to a diff with the previous version there as well - When I'm looking through the history I'm usually more interested in seeing what was changed, not how the file looked like after the fix.

vladak avatar May 22 '13 07:05 vladak

Once we determine how to get the previous revision number of the file, this should be easy to do in history.jsp.

vladak avatar Jan 24 '14 14:01 vladak

I realized this is not so simple, especially for files which have been renamed in the past. Also, the traversal needs to check for added files - if a file is new in particular changeset, the diff link should not be displayed (the history entries do not contain such information so we have to traverse it once again for each file in given changeset, leading to bigger computational complexity).

vladak avatar Jan 30 '14 10:01 vladak