opengrok
opengrok copied to clipboard
oracle
address isWorking() for other repository types
The fix for #3307 was done for GitRepository only. This bug tracks the rest of the repositories.
Hi @vladak Can you please explain me about this issue really interested to work on this issue
Explore the related issues and history. Specifically, for Git this was fixed in c47b7e716a31dc48f006bc51fc330c0b946affe3 (only to be removed by b289da3c) and for Mercurial in de458d8d. There are other types of SCMs under opengrok-indexer/src/main/java/org/opengrok/indexer/history/ that should receive the same treatment.
Hi @vladak, Thank you for your response Can you please tell me more about this issue I'm trying to understand
Hi @vladak, I'm willing to work on this issue, https://github.com/oracle/opengrok/tree/master/opengrok-indexer/src/main/java/org/opengrok/indexer/history In this tab, for which file is the problem araising for isWorking() function? can you specify the file, please.
Hey @vladak, https://github.com/oracle/opengrok/blob/03246776315da611de8587e903c16d2d6854a89c/opengrok-indexer/src/main/java/org/opengrok/indexer/history/MercurialRepository.java#L21 In this line, I think the year needs to be updated to 2023. please confirm. Thank you!
In which file does this problem arises, could you please specify one? Thank you!
Hey @vladak,
https://github.com/oracle/opengrok/blob/03246776315da611de8587e903c16d2d6854a89c/opengrok-indexer/src/main/java/org/opengrok/indexer/history/MercurialRepository.java#L21
In this line, I think the year needs to be updated to 2023. please confirm. Thank you!
please confirm regarding this one too!
In which file does this problem arises, could you please specify one? Thank you!
Basically in all Repository descendants that do not employ lazy loading of the working attribute.
Hey @vladak, https://github.com/oracle/opengrok/blob/03246776315da611de8587e903c16d2d6854a89c/opengrok-indexer/src/main/java/org/opengrok/indexer/history/MercurialRepository.java#L21
In this line, I think the year needs to be updated to 2023. please confirm. Thank you!
please confirm regarding this one too!
Looks fine to me. The file was last updated by Oracle employee in 2022.
