accelerated-data-science icon indicating copy to clipboard operation
accelerated-data-science copied to clipboard

[Bug]: List methods ignores limit kwarg

Open tanyakoganoracle opened this issue 1 year ago • 1 comments

Oracle-ads version used

  • [X] I have checked that this issue has not already been reported.

  • [X] I have confirmed this bug exists on the latest version of oracle-ads.

  • [X] I have confirmed this bug exists on the main branch of oracle-ads.

  • [X] I agree to follow Code of Conduct.

Description

DataScienceJob.list_jobs, ModelDeployment.list( compartment_id=oci_environment.compartment_id, project_id=oci_environment.project_id, limit=15 ) This methods ignores the limit variable. Maybe another similar methods for other classes too.

How to Reproduce

ModelDeployment.list(
    compartment_id=oci_environment.compartment_id,
    project_id=oci_environment.project_id,
    limit=15
)

What was Observed

returns a lot more then 15

What was Expected

Only 15 items

Version

oracle-ads==2.8.11

tanyakoganoracle avatar Apr 04 '24 19:04 tanyakoganoracle

Under the hood it is used the - list_call_get_all_results API, where the limit parameter will be ignored. We will check this.

mrDzurb avatar May 21 '24 00:05 mrDzurb