oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Math expressions can be cut off when they're at the bottom of the card

Open BenHenning opened this issue 4 years ago • 2 comments

Describe the bug Math expressions can be cut off when they're at the bottom of the card, likely due to the extra translation that we're doing.

To Reproduce Steps to reproduce the behavior:

  1. Play through most of 'The meaning of Equal Parts" Fractions lesson
  2. Reach the state starting with "Mr. Baker chuckled"
  3. Scroll to the bottom of the content card
  4. Observe that the 1/2 + 1/4 is being partially cut-off

Expected behavior The text box should grow (or have a bit of extra padding) to make up for potential LaTeX vertical space. We may just need to bake the vertical alignment into that drawable's bounds.

Screenshots image

Device

  • Device being used: Nexus 5X
  • SDK version: 27

Additional context Found during alpha MR2 testing.

BenHenning avatar Mar 24 '21 19:03 BenHenning

@BenHenning check if the issue is resolved. In my device it looks perfect both in portrait and landscape mode.

WhatsApp Image 2021-03-26 at 5 30 39 PM
WhatsApp Image 2021-03-26 at 5 30 39 PM (1)

imraghav20 avatar Mar 26 '21 12:03 imraghav20

@rt4914 adding you if this comes under content UI part.

anandwana001 avatar May 11 '21 08:05 anandwana001

For the concept card explanation text in concept_card_fragment.xml, the images are no longer truncated as this was resolved in #4669

5.6", dev 6.7", beta
Screenshot_1669718695 Screenshot_2022-11-29-13-42-42-480_org oppia android

adhiamboperes avatar Nov 29 '22 10:11 adhiamboperes

@adhiamboperes Just to check, do you mean that the original issue has been fixed?

(If not, which part of it is not fixed?)

seanlip avatar Mar 28 '23 15:03 seanlip

@seanlip yes this was fixed, I can nolonger reproduce this issue in the latest versions of dev and beta.

adhiamboperes avatar Mar 29 '23 03:03 adhiamboperes

Great, thanks! Closing it, then.

seanlip avatar Mar 30 '23 19:03 seanlip