fix(declcfg): collect informative errors in Load()
Description of the change: collect informative (name/package and schema type) errors in Load()
Motivation for the change: able to fix all load errors in one go.
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/docs - [ ] Commit messages sensible and descriptive
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: estroz
To complete the pull request process, please assign njhale after the PR has been reviewed.
You can assign the PR to them by writing /assign @njhale in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Merging #739 (814a5d7) into master (a0bb1e5) will increase coverage by
0.00%. The diff coverage is83.33%.
:exclamation: Current head 814a5d7 differs from pull request most recent head 0d8d078. Consider uploading reports for the commit 0d8d078 to get more accurate results
@@ Coverage Diff @@
## master #739 +/- ##
=======================================
Coverage 50.29% 50.29%
=======================================
Files 101 101
Lines 8699 8706 +7
=======================================
+ Hits 4375 4379 +4
- Misses 3471 3473 +2
- Partials 853 854 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| alpha/declcfg/load.go | 80.76% <80.00%> (-2.80%) |
:arrow_down: |
| alpha/declcfg/declcfg.go | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a0bb1e5...0d8d078. Read the comment docs.
/lgtm
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
closing as stale