Introduce golangci-lint to the repository
Description of the change: Adds the golangci-lint tool to the repository to consolidate the various linting checks into a single tool. Updates the GHA workflow to run the 'make lint' Makefile target during CI runs.
Motivation for the change: Closes #1000
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/docs - [ ] Commit messages sensible and descriptive
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: timflannagan
Once this PR has been reviewed and has the lgtm label, please assign ecordell for approval by writing /assign @ecordell in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
There's probably a bunch of linting violations here.
/hold
Codecov Report
Merging #1003 (439a228) into master (33ed9ea) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #1003 +/- ##
=======================================
Coverage 52.87% 52.87%
=======================================
Files 104 104
Lines 9468 9468
=======================================
Hits 5006 5006
Misses 3529 3529
Partials 933 933
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@timflannagan: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.