operator-registry icon indicating copy to clipboard operation
operator-registry copied to clipboard

Introduce golangci-lint to the repository

Open timflannagan opened this issue 3 years ago • 4 comments

Description of the change: Adds the golangci-lint tool to the repository to consolidate the various linting checks into a single tool. Updates the GHA workflow to run the 'make lint' Makefile target during CI runs.

Motivation for the change: Closes #1000

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

timflannagan avatar Jul 28 '22 22:07 timflannagan

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timflannagan Once this PR has been reviewed and has the lgtm label, please assign ecordell for approval by writing /assign @ecordell in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 28 '22 22:07 openshift-ci[bot]

There's probably a bunch of linting violations here.

/hold

timflannagan avatar Jul 28 '22 22:07 timflannagan

Codecov Report

Merging #1003 (439a228) into master (33ed9ea) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1003   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files         104      104           
  Lines        9468     9468           
=======================================
  Hits         5006     5006           
  Misses       3529     3529           
  Partials      933      933           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 28 '22 22:07 codecov[bot]

@timflannagan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Sep 23 '22 22:09 openshift-merge-robot