Add a goimportas linter configuration to enforce package import structure
Signed-off-by: timflannagan [email protected]
Description of the change: Add a goimports linter configuration to enforce packages from this repository are grouped correctly.
Motivation for the change: Make PR reviews more streamlined by automating style differences.
Architectural changes:
Testing remarks:
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Bug fixes are accompanied by regression test(s)
- [ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
- [ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
- [ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
- [ ] Docs updated or added to
/doc - [ ] Commit messages sensible and descriptive
- [ ] Tests marked as
[FLAKE]are truly flaky and have an issue - [ ] Code is properly formatted
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: exdx, timflannagan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [timflannagan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
There's a bunch of code changes that need to be made to make this new linting configuration happy. Holding for now until I have time to revisit this.
/hold