operator-framework
Added resource 'operator' to aggregated clusterrole
Description of the change:
Added the CRD operators to 0000_50_olm_09-aggregated.clusterrole.yaml
Motivation for the change:
Missing declaration for the CRD operators in aggregated clusterrole.
The CRD is: https://github.com/operator-framework/operator-lifecycle-manager/blob/master/deploy/chart/crds/0000_50_olm_00-operators.crd.yaml
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/doc - [ ] Commit messages sensible and descriptive
Hi @qhua948. Thanks for your PR.
I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@qhua948: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/ok-to-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: njhale, qhua948
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [njhale]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
We're running into some issues with e2e test failures recently. Throwing a hold so the bots don't go crazy trying to retest almost permafailing test cases. Let's try removing this hold towards the latter end of this week.
/hold
After thinking about this a bit more, I'm not sure that we want to grant all users the ability to view existing operators as it could bleed information between tenants, which is a security concern.
/hold
Given that this PR represents a possible security concern and the fact that this repository contains a number of PRs that have been open for an excessively long period of time, I'm going to close this PR. If you believe that this PR should still be merged, please reopen the PR and explain why.
We will eventually release an official policy detailing our process for handling "stale" PRs and issues. If you would like to be involved in the conversation, please engage through https://github.com/operator-framework/rukpak/pull/553.
Thank you,
Alex