cog icon indicating copy to clipboard operation
cog copied to clipboard

Investigate Piper's typing of options

Open christophermaier opened this issue 9 years ago • 2 comments

It appears that Piper isn't enforcing the declared types of option values, causing commands to manage this on their own.

If we could be certain that the data we receive in a command was the proper type, we could simplify a lot of the commands.

(If we could do the same with arguments, that would be useful as well, but would require changes to lots of other places as well, and would be much larger in scope.)

christophermaier avatar Feb 16 '16 19:02 christophermaier

When we fix this we should make sure that it's valid to send integer and boolean values to options that specify that they take strings, rather than forcing users to explicitly quote them. Since we know that integers and booleans are both safe to cast to strings we can do so before we create the CommandRequest.

imbriaco avatar Feb 24 '16 22:02 imbriaco

dependent on #340

mpeck avatar Mar 04 '16 16:03 mpeck