zipkin-ruby icon indicating copy to clipboard operation
zipkin-ruby copied to clipboard

Published 20 hours ago • verified publisher icon openzipkin

Spans are not sent to Zipkin sender when an error is thrown from a Sidekiq worker

Open ghost opened this issue 5 years ago • 2 comments

When an error bubbles up from this line the trace spans are never flushed https://github.com/openzipkin/zipkin-ruby/blob/master/lib/zipkin-tracer/sidekiq/middleware.rb#L31

This results in spans missing from the trace context in a Zipkin UI.

Was this behavior intentional?

ghost avatar Mar 11 '20 16:03 ghost

as the author of that middleware, @ayrat555 might be able to answer that question

jfeltesse-mdsol avatar Mar 12 '20 01:03 jfeltesse-mdsol

@brandon-zeeb-nw I think rescue (or ensure clause should be added to the middleware and send traces with exceptions there

ayrat555 avatar Mar 12 '20 09:03 ayrat555