zipkin-ruby

zipkin-ruby copied to clipboard

Spans are not sent to Zipkin sender when an error is thrown from a Sidekiq worker

2

When an error bubbles up from this line the trace spans are never flushed https://github.com/openzipkin/zipkin-ruby/blob/master/lib/zipkin-tracer/sidekiq/middleware.rb#L31 This results in spans missing from the trace context in a Zipkin UI. Was this...

ghost

Add setting to disable shared spans (joins) in tracer.

2

Other tracer implementations include a setting to force client and server spans to have different spanId's. In Go the setting is [`WithSharedSpans(false)`](https://godoc.org/github.com/openzipkin/zipkin-go#WithSharedSpans) and in Java it's [`supportsJoin(false)`](https://static.javadoc.io/io.zipkin.brave/brave/5.0.0/brave/Tracing.Builder.html#supportsJoin-boolean-). There should be...

tylerbenson

How to set the span version

1

I'd like to generate the span with V1 version for my application, is there any parameter used for this configuration?

dpdpbj

protect against double inserting middlewares

3

It seems that mistake do happen and does not look nice. Thoughts on the approach? I could not find a way to find out at initialization time. @ykitamura-mdsol @jfeltesse-mdsol

jcarres-mdsol

This request is similar to https://github.com/openzipkin/brave/issues/357. It would be nice to be able to configure the tracer to send certain tags by default. It _might_ be possible to override `end_span`...

karkum

Build a backend trace ruby library

5

I plan to to build a backend trace library, not only tracing the HTTP requests, that collects the span information of every method in the path and POST to zipkin...

littlegrasscao

Annotate http.url instead of http.path

6

I do not care about the host but I want the query parameters and could not find another standard annotation better than `url`. In many cases query parameters are key...

jcarres-mdsol

Besides traces are sampled and sent to collector, we wanna traces to be added to mdc, so that whenever there is a log line for a request the corresponding traceId...

xihw

Keep Getting Uninitialized Constant AsyncHttpApiClient::ZipkinHttpSender

1

Trying to integrate with our rails application, but keep getting this uninitialized constant error. Config looks like `require 'zipkin-tracer' require_relative 'config/environment' ZIPKIN_TRACER_CONFIG = { service_name: 'test', sample_rate: 1.0, json_api_host: 'http://localhost:9411'...

gjdame

replace hermann gem with ruby-kafka or otherwise

1

https://github.com/reiseburo/hermann has been dead for over 2 years and requires jruby https://github.com/zendesk/ruby-kafka looks very active

codefromthecrypt